Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TopologySpreadConstraint: advance above avg index when at ideal average #602

Merged
merged 1 commit into from
Aug 10, 2021
Merged

TopologySpreadConstraint: advance above avg index when at ideal average #602

merged 1 commit into from
Aug 10, 2021

Conversation

a7i
Copy link
Contributor

@a7i a7i commented Jul 14, 2021

When balancing domains, the above average index (i.e. j) should advance when equal ideal average.

Closes issue #601

@k8s-ci-robot
Copy link
Contributor

Hi @a7i. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 14, 2021
@a7i
Copy link
Contributor Author

a7i commented Jul 14, 2021

/assign @damemi

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 14, 2021
@a7i a7i force-pushed the balance-domains-aboveavg branch from 85656b9 to b0e5d64 Compare July 14, 2021 02:55
damemi
damemi reviewed Jul 30, 2021
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
(sorry for the delay @a7i, I was on vacation 🙂 )

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 30, 2021
@a7i
Copy link
Contributor Author

a7i commented Jul 30, 2021

@damemi No worries, hope you went somewhere fun! 🏖️

Now that you're back.. you have a lot of PRs to catch up on 😈

@damemi
Copy link
Contributor

damemi commented Aug 2, 2021

/approve
good catch @a7i!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a7i, damemi, uthark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2021
@damemi
Copy link
Contributor

damemi commented Aug 10, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit 64d7901 into kubernetes-sigs:master Aug 10, 2021
@seanmalloy
Copy link
Member

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 20, 2021
@seanmalloy seanmalloy mentioned this pull request Aug 20, 2021
Closed
@a7i a7i deleted the balance-domains-aboveavg branch August 20, 2021 12:19
briend pushed a commit to briend/descheduler that referenced this pull request Feb 11, 2022
Merge pull request kubernetes-sigs#602 from a7i/balance-domains-aboveavg
8dec841 
TopologySpreadConstraint: advance above avg index when at ideal average
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi left review comments

@uthark uthark uthark approved these changes

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@damemi damemi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@a7i @k8s-ci-robot @damemi @seanmalloy @uthark